Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions testing against Solidus versions that have reached EOL #2866

Closed
jacobherrington opened this issue Sep 25, 2018 · 4 comments
Closed

Extensions testing against Solidus versions that have reached EOL #2866

jacobherrington opened this issue Sep 25, 2018 · 4 comments

Comments

@jacobherrington
Copy link
Contributor

I would like to get some discussion on this:

I recently added a new Solidus versions to TravisCI in bunch of Solidus extensions. I noticed that some extensions have .travis.yml files that list a ton of Solidus versions which have now reach EOL.

(from solidus_i18n)

dist: trusty
sudo: required
addons:
  chrome: stable
cache: bundler
language: ruby
before_install:
  - gem update --system # https://github.com/travis-ci/travis-ci/issues/8978
  - gem install bundler
rvm:
  - 2.5
env:
  matrix:
    - SOLIDUS_BRANCH=v1.1 DB=postgres
    - SOLIDUS_BRANCH=v1.2 DB=postgres
    - SOLIDUS_BRANCH=v1.3 DB=postgres
    - SOLIDUS_BRANCH=v1.4 DB=postgres
    - SOLIDUS_BRANCH=v2.0 DB=postgres
    - SOLIDUS_BRANCH=v2.1 DB=postgres
    - SOLIDUS_BRANCH=v2.2 DB=postgres
    - SOLIDUS_BRANCH=v2.3 DB=postgres
    - SOLIDUS_BRANCH=v2.4 DB=postgres
    - SOLIDUS_BRANCH=v2.5 DB=postgres
    - SOLIDUS_BRANCH=v2.6 DB=postgres
    - SOLIDUS_BRANCH=v2.7 DB=postgres
    - SOLIDUS_BRANCH=master DB=postgres
    - SOLIDUS_BRANCH=v1.1 DB=mysql
    - SOLIDUS_BRANCH=v1.2 DB=mysql
    - SOLIDUS_BRANCH=v1.3 DB=mysql
    - SOLIDUS_BRANCH=v1.4 DB=mysql
    - SOLIDUS_BRANCH=v2.0 DB=mysql
    - SOLIDUS_BRANCH=v2.1 DB=mysql
    - SOLIDUS_BRANCH=v2.2 DB=mysql
    - SOLIDUS_BRANCH=v2.3 DB=mysql
    - SOLIDUS_BRANCH=v2.4 DB=mysql
    - SOLIDUS_BRANCH=v2.5 DB=mysql
    - SOLIDUS_BRANCH=v2.6 DB=mysql
    - SOLIDUS_BRANCH=v2.7 DB=mysql
    - SOLIDUS_BRANCH=master DB=mysql

This kind of thing causes tests to take a lot longer, and in some cases when CI hangs, tests can take a really long time.

Should we only be testing extensions against versions that haven't reached EOL?
@tvdeyen
Copy link
Member

tvdeyen commented Sep 25, 2018

Should we only be testing extensions against versions that haven't reached EOL?

No. Although we have a rule of supporting as much as Solidus versions as possible, the amount of resources we are burning alone is reason to not to.

It does not make any sense to do not support the Solidus version of it, but still test the extension for it.

This was referenced Sep 25, 2018
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
jacobherrington added a commit to solidusio-contrib/solidus_trackers that referenced this issue Sep 25, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
b1d89ed 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
@jacobherrington jacobherrington mentioned this issue Sep 25, 2018
Merged
jacobherrington added a commit to solidusio/solidus_subscriptions that referenced this issue Sep 25, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
4a7f936 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
This was referenced Sep 25, 2018
Merged
Merged
Merged
Merged
Merged
@jacobherrington
Copy link
Contributor Author

Pretty sure I made PRs to all of the Solidus Extensions from http://extensions.solidus.io/ that are still running against EOL versions. I'll leave the issue open for now in case there is more discussion.

@jacobherrington
Copy link
Contributor Author

If we stop testing against EOL versions as a rule, should this toggle on http://extensions.solidus.io/ go away?

screen shot 2018-09-25 at 12 20 14 pm

jacobherrington pushed a commit to jacobherrington/solidus that referenced this issue Sep 25, 2018
Update .travis.yml example to non EOL versions
bbbf565 
Testing versions of Solidus that have reached EOL is a
misuse of resources and should be avoided. The
extension documentation should reflect the practice
of only testing versions that are currently supported.

Refs solidusio#2866
@jacobherrington jacobherrington mentioned this issue Sep 25, 2018
Merged
@tvdeyen
Copy link
Member

tvdeyen commented Sep 25, 2018

should this toggle on http://extensions.solidus.io/ go away?

Yes. Very good catch

jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 20, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
90cc163 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 23, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
ce1fc32 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 24, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
58828a0 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 24, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
70ec6de 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 24, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
e4b5c87 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 26, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
f8cd38f 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Nov 26, 2018
@jacobherrington
Remove versions past EOL from .travis.yml
74d12e0 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_product_feed that referenced this issue Dec 19, 2018
Remove versions past EOL from .travis.yml
a0d75fc 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_trackers that referenced this issue Feb 6, 2019
@jacobherrington
Remove versions past EOL from .travis.yml
ca50a38 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
jtapia pushed a commit to jtapia/solidus_multi_domain that referenced this issue Apr 5, 2019
Remove versions past EOL from .travis.yml
6c9ec84 
Refs solidusio/solidus#2866 (comment)

There is no reason to invest resources in testing extensions against Solidus versions that have passed EOL.

[Solidus Version Maintenance/EOL policy](https://solidus.io/blog/2018/01/04/maintenance-eol-policy.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvdeyen @jacobherrington