Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid method used in the the AddApplyToAllToVariantPropertyRule migration #3809

Closed
ok32 opened this issue Oct 25, 2020 · 0 comments
Closed

Invalid method used in the the AddApplyToAllToVariantPropertyRule migration #3809

ok32 opened this issue Oct 25, 2020 · 0 comments

Comments

@ok32
Copy link

ok32 commented Oct 25, 2020

I think this one should be up instead of change:

solidus/core/db/migrate/20180416083007_add_apply_to_all_to_variant_property_rule.rb

Line 4 in 44da6ff

def change

Otherwise it's impossible to reverse this migration.
ok32 pushed a commit to ok32/solidus that referenced this issue Oct 29, 2020
Use the right method in the AddApplyToAllToVariantPropertyRule migration
31850e3 
I think `change` is used here by a mistake.

Closes solidusio#3809
@ok32 ok32 mentioned this issue Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ok32 @kennyadsl