Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Create preview for all components #5221

Closed
waiting-for-dev opened this issue Jul 5, 2023 · 0 comments
Closed

[Admin] Create preview for all components #5221

waiting-for-dev opened this issue Jul 5, 2023 · 0 comments
Labels
type:enhancement Proposed or newly added feature

Comments

@waiting-for-dev
Copy link
Contributor

After #5213 has been merged, we might want to create previews for the rest of the components in the codebase.
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Jul 5, 2023
@waiting-for-dev waiting-for-dev mentioned this issue Jul 5, 2023
Merged
3 tasks
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jul 6, 2023
@waiting-for-dev
Add the preview for the sidebar admin component
218a164 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. solidusio#5221
@waiting-for-dev waiting-for-dev mentioned this issue Jul 6, 2023
Merged
3 tasks
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jul 7, 2023
@waiting-for-dev
Add component preview for the sidebar item component
1470738 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the request object
on initialization so we can mock the full path and set the active state
from outside. However, as the actual request object is only available on
render time for the component, we need to set it on a `before_render`
hook unless a mocked one has been provided.

Closes solidusio#5221
@waiting-for-dev waiting-for-dev mentioned this issue Jul 7, 2023
Merged
3 tasks
elia pushed a commit that referenced this issue Jul 11, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
565cf18 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jul 12, 2023
@waiting-for-dev
Add component preview for the sidebar item component
8529a8c 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes solidusio#5221
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Jul 13, 2023
@waiting-for-dev
Add component preview for the sidebar item component
c7f9965 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes solidusio#5221
@chrean chrean closed this as completed Jul 19, 2023
elia pushed a commit that referenced this issue Aug 2, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
969459b 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Aug 2, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
071d753 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
waiting-for-dev added a commit that referenced this issue Aug 8, 2023
@waiting-for-dev
Add the preview for the sidebar admin component
5c043e8 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
waiting-for-dev added a commit that referenced this issue Aug 8, 2023
@waiting-for-dev
Add component preview for the sidebar item component
7095585 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
waiting-for-dev added a commit that referenced this issue Aug 9, 2023
@waiting-for-dev
Add the preview for the sidebar admin component
b467149 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
waiting-for-dev added a commit that referenced this issue Aug 9, 2023
@waiting-for-dev
Add component preview for the sidebar item component
6f6db4b 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Sep 25, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
89e55cd 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Sep 25, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
caddbaa 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Sep 27, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
50234fe 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Sep 27, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
0e4bb08 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Sep 28, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
304e78c 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Sep 28, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
2fdd160 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Sep 28, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
62dfd20 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Sep 28, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
5507225 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Sep 29, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
7fa58b8 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Sep 29, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
af4783a 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
elia pushed a commit that referenced this issue Oct 6, 2023
@waiting-for-dev @elia
Add the preview for the sidebar admin component
1c29386 
We inject a tweaked item component to avoid rendering actual links in
the embedded preview.

We'll leave the preview of active state of the main navigation to the
item component preview.

Ref. #5221
elia pushed a commit that referenced this issue Oct 6, 2023
@waiting-for-dev @elia
Add component preview for the sidebar item component
ba16388 
We mock the url helpers so the dummy route we use points to the
current page.

At the same time, we change the item component to get the fullpath on
initialization so we can mock and set the active state from outside.

Closes #5221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waiting-for-dev @chrean