-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Reuse typography styles #5231
Comments
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this issue
Jul 10, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes solidusio#5231
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this issue
Jul 10, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes solidusio#5231
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this issue
Jul 10, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes solidusio#5231
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this issue
Jul 11, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes solidusio#5231
elia
pushed a commit
that referenced
this issue
Aug 2, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
waiting-for-dev
added a commit
that referenced
this issue
Aug 8, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
waiting-for-dev
added a commit
that referenced
this issue
Aug 9, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Sep 25, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Sep 27, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Sep 28, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Sep 28, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Sep 29, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
elia
pushed a commit
that referenced
this issue
Oct 6, 2023
We're creating custom Tailwind classes, as our design system contains a set of well-defined font sizes, line heights, families and weights that only combine in a few ways. That will help us keep the admin's typography consistent and easy to maintain. We're leaving out for now styles for headings, as they're not used yet and they might require adding a new font family. Closes #5231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The design we're following contains a clearly defined set of typography styles, where only a specific combination of font family, size, line height, and weight are allowed. Therefore, it will be beneficial to group them in custom Tailwind classes to avoid boilerplate and make contributions easier. That's not at the expense of using some other techniques to prevent code duplication, like having a custom component for titles, which will also probably be implemented.
The text was updated successfully, but these errors were encountered: