Upgrade path for shipping rate tax data #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! Thank you very much @mamhoff |
|
I'm very much happy with this compromise 👍 |
|
👍 |
| task up: :environment do | ||
| puts "Adding persisted tax notes to historic shipping rates" | ||
| Spree::ShippingRate.where.not(tax_rate_id: nil).find_each do |shipping_rate| | ||
| tax_rate = Spree::TaxRate.unscoped.find_by(id: shipping_rate.tax_rate_id) |
There was a problem hiding this comment.
Any reason just to not use find?
There was a problem hiding this comment.
No particular reason. Should I amend?
Previously, we had a migration that deleted the `tax_rate_id` column from the `spree_shipping_rates` table. Within that migration, we could not satisfactorily create shipping rate taxes because that required a call to `Spree::TaxRate#compute_amount`, for which we can not guarantee the interface for all future Solidus versions to come. This compromise works as follows: We keep the column and provide a rake task to migrate that data up. In a future release (maybe 2.0), we can then add a migration to delete the column that errors out if there's still data on it (indicating the migration hasn't been run).
|
Amended to use |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a migration that deleted the
tax_rate_idcolumnfrom the
spree_shipping_ratestable. Within that migration, we could notsatisfactorily create shipping rate taxes because that required a call to
Spree::TaxRate#compute_amount, for which we can not guarantee the interfacefor all future Solidus versions to come.
This compromise works as follows: We keep the column and provide a rake task to
migrate that data up. In a future release (maybe 2.0), we can then add a migration
to delete the column that errors out if there's still data on it (indicating the
migration hasn't been run).