Migrations to fix up default store and store_id on orders #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change to the CreateStoreFromPreferences migration caused the store to no longer be set as a default. This updates that migration to set the store it is creating as the default. This also adds a later migration to set the first store to the default if there is not an existing default. Since the CreateStoreFromPreferences migration will be run very shortly after the creation of the Store table, this should be a safe assumption.
This does the same job as the existing solidus:migrations:ensure_store_on_orders:up rake task, but is a migration so that it is easier to run.
jhawthorn
changed the title
|
Thanks John! Does this not make the rake task obsolete and delete-worthy then? The migrations will be run before the rake tasks, so... Otherwise, 👍 |
|
I will submit a second PR for removing the rake task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun off of #1224 and #1225
This PR accomplishes two things:
A previous change to the
CreateStoreFromPreferencesmigration caused the store to no longer be set as a default.This updates that migration to set the store it is creating as the default. This also adds a later migration to set the first store to the default if there is not an existing default. Since the
CreateStoreFromPreferencesmigration will be run very shortly after the creation of the Store table, this should be a safe assumption.This should fix issues like #1150
Adds a migration which is the equivalent of
rake solidus:migrations:ensure_store_on_orders:up