[RFC] Raise exception when there is no default store #1232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
raise_on_no_default_store
branch
2 times, most recently
from
4e79375 to
4b7ce4b
Compare
jhawthorn
force-pushed
the
raise_on_no_default_store
branch
2 times, most recently
from
ba27242 to
771fe7c
Compare
jhawthorn
force-pushed
the
raise_on_no_default_store
branch
from
771fe7c to
e85ed8e
Compare
| @@ -818,7 +813,8 @@ def merge!(other_order, user = nil) | |||
|
|
|||
| # Regression test for https://github.com/spree/spree/issues/4923 | |||
| context "locking" do | |||
| let(:order) { Spree::Order.create } # need a persisted in order to test locking | |||
| let(:store) { create(:store) } # need a persisted in order to test locking | |||
| let(:order) { Spree::Order.create(store: store) } # need a persisted in order to test locking | |||
There was a problem hiding this comment.
The comment is missing a word, maybe store?
|
I'm a fan. 💯 |
|
I'm still a fan of this. @jhawthorn whenever you have a minute would you mind rebasing this on the current master branch? |
|
@jhawthorn any chance to look into this again? |
jhawthorn
force-pushed
the
raise_on_no_default_store
branch
from
e85ed8e to
cfbb3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to investigate what it would look like to raise an exception on
Store.current/Store.defaultif there was no default store in the database.As you can see there are a lot of spec changes needed to accomplish this, but not an obscene amount. We should think that it will be similar for users upgrading.
Some of the required changes were to avoid the "General Settings" page of the admin (which is actually a page to edit the default store). It would probably be helpful if we could make that page not error as part of #1189