Move spree user methods to module #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| error = "Spree.user_class MUST be a String or Symbol object, not a Class object." | ||
| raise error if @@user_class.is_a?(Class) | ||
|
|
||
| if !@@user_class.constantize.included_modules.include? Spree::UserMethods |
There was a problem hiding this comment.
Would this work instead?
if !@@user_class.constantize.is_a? Spree::UserMethods
There was a problem hiding this comment.
No, @@user_class.constantize is a class. After talking with @jhawthorn, figured out it would need to be @@user_class.constantize.new.is_a? ... but that we didn't like that syntax
|
test this please |
1 similar comment
|
test this please |
| @@ -11,58 +11,58 @@ class BaseController < Spree::BaseController | |||
|
|
|||
There was a problem hiding this comment.
the changes in this file seem unrelated, and the previous style didn't necessarily break a convention, do you mind backing them out?
Also update LegacyUser to include User methods and move appropriate methods into the UserMethods module
Add deprication warning to initializer. If User class doesnt include UserMethods, add it and warn.
For api compatibility
|
|
||
| if !methods_included | ||
| ActiveSupport::Deprecation.warn "#{ Spree.user_class.name } must include Spree::UserMethods" | ||
| Spree.user_class.class_eval { include UserMethods } |
There was a problem hiding this comment.
You don't need to class_eval this.
Spree.user_class.include UserMethods
I like the deprecation warning getting people to move this to their own definition rather than hacking it in for them.
|
This was merged in #153 |
Senjai
pushed a commit
to Senjai/solidus
that referenced
this pull request
Feb 17, 2016
Remove default_price unscoping
JDutil
added a commit
to JDutil/solidus
that referenced
this pull request
Mar 26, 2020
Fix Teaspoon @ 1.1.5
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
…for-friendly-promotions Use different path for friendly promotions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Spree::User logic into a mixin that can be included in the Spree.user_class that is defined.