Rescue Spree::Order::InsufficientStock in backend #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 (pending whitespace fixes) Thanks for the specs |
When an order contains a line_item which requires a quantity greater than available in not backorderable stock items, a Spree::Order::InsufficientStock exception is raised, but there are no rescue in controllers. This change adds the rescue for Payments and CustomerDetails controllers, displays an `:insufficient_stock_for_order` error message and redirects to the specific page.
DanielePalombo
force-pushed
the
backend-detect-insufficient-stock
branch
from
0d8442a to
566f3b2
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an order contains a line_item which requires a quantity greater
than available in not
backorderable stock items, a Spree::Order::InsufficientStock exception
is raised, but there
are no rescue in controllers.
This change adds the rescue for Payments and CustomerDetails
controllers, displays an
:insufficient_stock_for_ordererror message and redirects to thespecific page.
Still needs to be ported in Spree::Api controllers
ref #566