Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackers from Solidus #1438

Merged
merged 10 commits into from
Sep 19, 2016
Merged

Remove trackers from Solidus #1438

merged 10 commits into from
Sep 19, 2016

Conversation

swively
Copy link
Contributor

@swively swively commented Sep 13, 2016

Previously, Solidus shipped with an admin panel that allowed creation of trackers.
This functionality is now available in an extension, solidus_trackers

https://github.com/solidusio-contrib/solidus_trackers

@cbrunsdon
Copy link
Contributor

I am very pro this. I think most people end up implementing GA on their own and don't use these views, let alone the Tracker models. Maybe we want to have a different GA extension that implements a reasonable set of views? But definitely this is a good step forward.

👍

Though we will probably want to move the external extension into solidus-contrib.

Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a good direction to go in. However, I would like to see this functionality extracted to an extension (we can host it on solidus-contrib) and an entry in the Changelog to note how to get things working again.

@jhawthorn
Copy link
Contributor

Trackers are a great fit for an extension. They integrate very loosely with the rest of solidus, and most users will be rolling their own analytics (especially as google is not the only name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants