Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some yarddocs from @return [undefined] to @return [void] #1454

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Change some yarddocs from @return [undefined] to @return [void] #1454

merged 1 commit into from
Sep 19, 2016

Conversation

jordan-brough
Copy link
Contributor

@jordan-brough jordan-brough mentioned this pull request Sep 19, 2016
Merged
jhawthorn
jhawthorn approved these changes Sep 19, 2016
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cbrunsdon
Copy link
Contributor

Good by me too thanks 👍

@jordan-brough jordan-brough merged commit 548982e into solidusio:master Sep 19, 2016
@jordan-brough jordan-brough deleted the return-undefined branch September 19, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordan-brough @cbrunsdon @jhawthorn