Fix Shipment#update_attributes_and_order - run full order updater #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-brough
force-pushed
the
update-shipments-taxes
branch
from
bc39758 to
dc70aa7
Compare
gmacdougall
approved these changes
Oct 11, 2016
mamhoff
approved these changes
Oct 11, 2016
|
What was the issue in the |
|
@jhawthorn see the commit message on the first commit:
Yah I can create a spec for that. Will do. |
|
@jhawthorn I've added a spec for the factory |
jhawthorn
reviewed
Nov 8, 2016
|
|
||
| create(:shipment, order: order, cost: evaluator.shipment_cost, shipping_method: evaluator.shipping_method, stock_location: evaluator.stock_location) | ||
| order.shipments.reload | ||
|
|
||
| order.create_tax_charge! |
There was a problem hiding this comment.
I think this is no longer necessary thanks to your work in #1479
This order wasn't set up in a valid way. Just running `order.update!` would mess up the test values.
Tax charges aren't being updated when the shipping method changed because some parts of OrderUpdater aren't being run in `Shipment#update_attributes_and_order`.
Tax charges aren't being updated when the shipping method changes because some parts of OrderUpdater aren't being run in `Shipment#update_attributes_and_order`.
jhawthorn
force-pushed
the
update-shipments-taxes
branch
from
52c1995 to
86f2e33
Compare
|
@jordan-brough I rebased and removed the first commit, which was unnecessary as of #1479 🎉 |
|
I also think that this simplification is brilliant, and @gmacdougall said it all very well. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tax charges aren't being updated when the shipping method changes
because some parts of OrderUpdater aren't being run in
Shipment#update_attributes_and_order.Also fix an issue in order_factory around shipment taxes.
See individual commits.