Add tooltip to store cart tax iso country field #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a tooltip using the new `field_hint` method. However, `field_hint` does not currently work with `fields_for`, which is why this PR removes the `fields_for` call and instead uses a full form object for just the store. Advantages: We now limit the `GeneralSettingsController` to only change things for the store. Disadvantages: See advantages - if anyone patched their `GeneralSettingsController`, this would be an issue.
mamhoff
changed the title
mamhoff
changed the title
cbrunsdon
approved these changes
Oct 26, 2016
jhawthorn
approved these changes
Oct 27, 2016
|
I make further changes in #1282, which I will rebase to include this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tooltip using the new
field_hintmethod.However,
field_hintdoes not currently work withfields_for, which iswhy this PR removes the
fields_forcall and instead uses a full form objectfor just the store.
Advantages: We now limit the
GeneralSettingsControllerto only change things for the store.Disadvantages: See advantages - if anyone patched their
GeneralSettingsController,this would be an issue.