Avoid re-creating tax adjustments #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One potential issue I've spotted is that this has changed the behaviour of an existing tax rate which had an amount and then later became
|
This is done in the interest of having as few special cases as possible. Nothing in our test swite exposed this functionality, and it's probably not a case worth optimizing for.
Previously, ItemAdjuster#adjust! would always destroy all tax adjustments on the item and recreate them. This was unnecessarily slow in the common case of needing no changes (especially following solidusio#1479). This changes ItemAdjuster#adjust! to instead update the adjustment for a rate if it already exists, create adjustments if they are missing for a matching rate, and destroy adjustments for rates which are no longer matching.
jhawthorn
force-pushed
the
avoid_recreating_tax_adjustments
branch
from
cbc7062 to
c661c04
Compare
|
I actually like the 0 amount better then no adjustment at all, there is a difference accounting-wise between 0 amount tax and no tax. |
|
👍 |
mamhoff
approved these changes
Nov 23, 2016
cbrunsdon
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ItemAdjuster#adjust!would always destroy all tax adjustments on the item and recreate them. This was unnecessarily slow in the common case of needing no changes (especially following #1479).This changes
ItemAdjuster#adjust!to instead update the adjustment for a rate if it already exists, create adjustments if they are missing for a matching rate, and destroy adjustments for rates which are no longer matching.With this change, the speed of an
order.update!which requires no changes is comparable to before #1479 🎉Comparison of queries run