Make frontend prices depend on store.cart_tax_country_iso
#1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
approved these changes
Nov 22, 2016
gmacdougall
approved these changes
Nov 23, 2016
cbrunsdon
approved these changes
Nov 25, 2016
|
I think it's worth being mentioned in the changelog |
Prior to this change, prices in the frontend portion of Solidus would depend on the setting for selecting prices in the backend, which is not store-specific, but global. However, we want prices to be different in the frontend if we change store and there are different prices.
mamhoff
force-pushed
the
use-current-store-cart-tax-country-iso-for-frontend-pricing
branch
from
c8fc855 to
51100ef
Compare
|
Added a short changelog entry (although I think it's really a bugfix). |
|
Thanks. IMO bug fixes are also worth to be mentioned in a changelog. Someone might want to see if an update is worthwhile because the long awaited bug fix finally landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, prices in the frontend portion of Solidus would
depend on the setting for selecting prices in the backend, which is not
store-specific, but global. However, we want prices to be different in the
frontend if we change store and there are different prices.