Remove method missing helper #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
reviewed
Nov 29, 2016
| style if style.in? possible_styles.with_indifferent_access | ||
| end | ||
| end | ||
|
|
||
| def create_product_image_tag(image, product, options, style) |
jhawthorn
suggested changes
Nov 29, 2016
gevann
force-pushed
the
remove-method-missing-helper
branch
from
72d447b to
c372425
Compare
gevann
force-pushed
the
remove-method-missing-helper
branch
from
c372425 to
dcb72f2
Compare
Remove image_style_from_method_name Remove define_image_method Remove custom-image-helper-context specs. Custom image helpers have been removed. Since this feature is no longer provided, remove test of them. Remove create_product_image_tag
gevann
force-pushed
the
remove-method-missing-helper
branch
from
dcb72f2 to
a5f9c02
Compare
jhawthorn
approved these changes
Nov 30, 2016
|
The day has finally come 👏🏻 |
|
Hah, indeed so Thomas .. those have been quite a trickery to grep. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the method_missing override from core base helpers, which removes the custom image helper functionality and accompanying specs.