Clean up Ransack query to find orders by promotion #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit optimizes the query used when attempting to find orders that used a promotion code, by going directly through the `spree_orders_promotions` table, resulting in one fewer JOIN in the resulting query. As the `spree_orders`, `spree_promotions`, and `spree_promotion_codes` tables can be quite large for some stores, skipping a JOIN significantly increase performance for these sorts of queries.
cbrunsdon
approved these changes
Dec 30, 2016
jhawthorn
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit optimizes the query used when attempting to find orders that
used a promotion code, by going directly through the
spree_orders_promotionstable, resulting in one fewer JOIN in theresulting query.
As the
spree_orders,spree_promotions, andspree_promotion_codestables can be quite large for some stores, skipping a JOIN significantly
increase performance for these sorts of queries.