Don't send email if PromotionCodeBatch email is unset #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PromotionCodeBatch has an email attribute, an email address which will
receive a notification when the batch job has completed.
Previously if this email field was empty, it would fail with
An SMTP To address is required to send a message. Set the message smtp_envelope_to, to, cc, or bcc address.
Instead, we should not send an email if the email field is blank
tvdeyen
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PromotionCodeBatch has an email attribute, an email address which will
receive a notification when the batch job has completed.
Previously if this email field was empty, it would fail with
Instead, we should not send an email if the email field is blank