Do not clear roles when no role params are present #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to be backported to v1.4 as this bug is also present in 1.4.0 |
|
Just saw that we need a fix for the missing "empty role ids param" in the users form and feature spec. Let me add this as well |
|
@Senjai done |
tvdeyen
force-pushed
the
fix-admin-users-role-update
branch
from
01b60d0 to
d88864c
Compare
|
@tvdeyen lgtm, thanks. |
Senjai
approved these changes
Feb 28, 2017
|
Oh. Thanks John. Let me rebase this. |
There is a regression where updating a user in the admin without spree role ids in the params causes the current user roles being wiped out. Also fixed a spec that only passed because of this bug being present.
In HTML unchecked checkboxes won’t get submitted in a form. That’s why Rails’ `check_box` helper always sets a hidden field with the same name. This field will be submitted when the checkbox is not checked and will be ignored when the checkbox is set. As we don’t use Rails’s `check_box` helper but `check_box_tag` helper in the admin users form role checkboxes we need to add this hidden field ourselves.
tvdeyen
force-pushed
the
fix-admin-users-role-update
branch
from
1f118a1 to
56866ed
Compare
|
@jhawthorn rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression where updating a user in the admin without spree role ids in the params causes the current user roles being wiped out.
Also fixed a spec that only passed because of this bug being present.