Replace select2-rails with vendored select2 #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select2 3.5.2 changed the way the hidden select element is hidden. Instead of just being offscreen it is now actually hidden (display: none). This affects how capybara treats the original select element.
In order to use select2 within sprockets we need to use image-url in the
CSS in order to reference the fingerprinted asset URLs.
sed -i "s/url('\\([^']*\\)')/image-url('solidus_admin\\/\\1')/g" select2.css
Also adds a select2_locales/index.js to make it easy to precompile all
locales.
Removes the select2-rails gem in favour of using the vendored version.
jhawthorn
force-pushed
the
select2_vendor
branch
from
6a214f9 to
9ac5279
Compare
cbrunsdon
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We favour using vendored assets in the admin to allow developers to use different versions of the same library in storefronts.
This is especially desirable for select2, because we are using the 3.5 version, which has some significant API changes from the current 4.0 version. If we upgrade to 4.0, storefronts should be able to keep using 3.5 if they want.
This has the side effect of cleaning up our
solidus_backend_manifest.js