Raise font-size #1777
Raise font-size #1777
Conversation
tvdeyen
force-pushed
the
larger-admin-font-size
branch
from
7bf867d to
27fc1da
Compare
|
If we're tweaking font sizes, I think we should remove some strange font size rules. Otherwise we risk calibrating the base font size wrong because the elements we look at are at For example: Fixing these should make the fonts even larger at the same time, which I think aligns with your goals 😄 . |
|
I would love to see a plan to deal with text that doesn't fit. I suspect if this happens at all it would be in the table headers. I'd be ok with truncating it like we do the admin email in the left hand column until we get a better layout sorted out. |
👍
I don't think it's a good idea to truncate table headers. IMO they transport important information. But I may be wrong. I would like to widen the default container width from 960px to ~1080px instead. |
|
Most ideally we would use the newly introduced full width layout everywhere, but this would cause adjustments to the search forms most of the tables have. Maybe introduce a max width container for the search form? |
|
The full width layout is for the listing pages with tables, but if there was a small table in a mostly form page I had hypothesized that text may not fit as shown in the example below. In the case that the text overflowed the table header that it was in, I thought it better to truncate it. Now thinking about it further, the best solution would be to simple wrap the text. :)
|
|
This could work. Alternatively we could remove columns that hold secondary information on smaller viewports. Hard to figure out which one is the secondary information though. |
tvdeyen
force-pushed
the
larger-admin-font-size
branch
from
27fc1da to
d96d113
Compare
|
@Mandily @jhawthorn I removed the change of the body font size and fixed the sizing in |
All fieldsets (and we use lots of them) have a font size of 90% (11.3px). With our base font size of 13px this leads to very small font sizes (10.53px) in all forms inputs (that have an additional 90% font-size) as most of them sit in a fieldset. Also removes a lot of styles already defined by Bootstrap and styles that needed to be resetetted as the fieldset was defined as part of the default input field styles.
The font size in the admin main navigation was lowered to 90%, what is very small as we have a base font size of 13px.
tvdeyen
force-pushed
the
larger-admin-font-size
branch
from
d96d113 to
bae3ad6
Compare
|
👍 |
|
This is looking much better. @tvdeyen was there supposed to be a change to |
|
@jhawthorn yes, but before we do that we want to do some preparations with #1780 and #1786 Otherwise raising the font size just won't look good. |
Probably solidusio#1777 introduced some visual bugs. This commit: - adjusts width of the whole datepicker to adapt to its content, was: width: 17em; - gives more spaces to arrows that currently are not completely shown
All our forms are nested in field sets, which have a font-size of 90%. Also our form field font sizes are reduced by 10%. With our base font size of 13px this leads to a 10.5px font size. This is definitely too small for modern screen sizes.
Before
After