Allow fulfilling all items of a ready shipment from another location #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 18, 2017
| create( | ||
| :order_ready_to_ship, | ||
| number: "R100", | ||
| line_items_attributes: [{variant: variant, quantity: 5}] |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
houndci-bot
reviewed
Mar 18, 2017
| create( | ||
| :order_ready_to_ship, | ||
| number: "R100", | ||
| line_items_attributes: [{variant: variant, quantity: 5}] |
There was a problem hiding this comment.
Space inside { missing.
Space inside } missing.
mamhoff
force-pushed
the
fix-fulfilling-ready-shipments-from-another-location
branch
from
77c7276 to
842222f
Compare
Prior to this commit, this would not work because the destruction of the original shipment would result in an exception being thrown. Ready shipments can be edited and thus have to be able to be destroyed, too. Fixes solidusio#1684
mamhoff
force-pushed
the
fix-fulfilling-ready-shipments-from-another-location
branch
from
842222f to
f6ef710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, this would not work because the destruction
of the original shipment would result in an exception being thrown.
Ready shipments can be edited and thus have to be able to be destroyed, too.
Fixes #1684