Avoid some stubbing in payment spec #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stubbing no longer worked under rails 5.1 and was hiding behaviour of our system under test
jordan-brough
approved these changes
Mar 29, 2017
| payment.payment_method = gateway | ||
| payment.amount = 5 | ||
| payment | ||
| Spree::Payment.create! do |payment| |
There was a problem hiding this comment.
Just curious - any reason not to use the payment factory here?
There was a problem hiding this comment.
I had the same doubt and I noticed that in this same file payments are also created using Spree::PaymentCreate.new Service Object. Is there any reason/general rule to prefer a method or another?
There was a problem hiding this comment.
I prefer using just described_class.create in the spec for the model itself, otherwise you are testing the factory's output at the same time.
We probably shouldn't be using PaymentCreate in this file (that should be in the payment_create_spec.rb file), I suspect that's here because PaymentCreate replaced an some old payment behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stubbing no longer worked under rails 5.1 and was hiding behaviour of our system under test
Part of the work on #1788