Remove click event from payments diplay amount #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Apr 3, 2017
In order payments table the amounts are currently clickable. As the edit icon is only displayed if the payment is pending, the amount is always clickable. Instead of making this conditional I removed this feature all together as I don't see any of this behaviour in any other admin table.
tvdeyen
force-pushed
the
avoid-editing-payments-amount-display
branch
from
d566395 to
ca5e4d9
Compare
jhawthorn
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order payments table the amounts are currently clickable.
As the edit icon is only displayed if the payment is pending,
the amount is always clickable.
Instead of making this conditional I removed this feature all together
as I don't see any of this behaviour in any other admin table.