Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bootstrap input-group for date range #1817

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Apr 3, 2017

Since #1782, the "date range" fields have looked off because they had a hardcoded size.

This PR groups the two inputs and the separator together inside a bootstrap input-group

This changes all uses of this pattern throughout the admin.

The line-height of the separator is slightly off under our current bootstrap, this is fixed by #1816 (used in screenshot above).

@jhawthorn jhawthorn added changelog:solidus_backend Changes to the solidus_backend gem UI labels Apr 3, 2017
@jhawthorn jhawthorn requested a review from tvdeyen April 3, 2017 20:45
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 super.

this really could be a partial, right?

tvdeyen
tvdeyen previously requested changes Apr 4, 2017
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I have a double border on the addon

orders 2017-04-04 08-57-52

Also the line height seems to be off. Fixed it with:

.input-group-addon:not(:first-child):not(:last-child) {
  border-left: 0 none;
  border-right: 0 none;
  line-height: $line-height;
}

orders 2017-04-04 09-02-59

@jhawthorn jhawthorn dismissed tvdeyen’s stale review April 5, 2017 22:22

Also fixed by #1816 (which is merged)

@jhawthorn jhawthorn merged commit 9c9e8f5 into solidusio:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants