Change how line item options are allowed in line items controller #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 23, 2017
|
|
||
| context 'when the line items have custom attributes' do | ||
| it "can create an order with line items that have custom permitted attributes" do | ||
| PermittedAttributes.line_item_attributes << {options: [:some_option] } |
|
This looks good to me, but needs a changelog entry for people who have overridden or used that class attribute. Also, would you mind squashing the Hound appeasement into the previous commit? |
gus4no
changed the title
|
@mamhoff Changelog updated and commits squashed! :) |
mamhoff
approved these changes
May 23, 2017
There was a problem hiding this comment.
Looks goot to me. @jhawthorn would you mind evaluating this PR?
|
Thanks, looking forward to trying this out! |
This was referenced May 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1131
Don't really know if this is the right way.. but old logic and issue reported seemed confusing to me, apparently it was just a bad setup of permitted attributes.
I just had the line items controller changed to make more sense, and got rid of that class attribute.
Permitted controllers are working now, old test are still green and I added a new test to confirm that orders are being created properly with line items with options.