Use validates_email_format_of gem in EmailValidator #1965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating email addresses is deceptively complicated. Rather than do it entirely ourselves, we can use this 'validates_email_format_of' gem which closely follows widely-accepted standards and has a strong test suite.
This commit replaces a simplistic regular expression that was flagging invalid emails as valid. Instead, we will now use ValidateEmailFormatOf to provide more robust email validation. See issue #1794 for details
|
I don't think we should add another dependency to core for this task. Most authentication solutions come with email validation of sorts, and the needs people have for this vary wildly. I specifically didn't add the Hack Day label to this one because it's much harder than it initally seems... |
|
We discussed this in the core team, and we all think we should not try handling email validation in core. Closing this - thank you for the effort though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a simplistic regular expression that was flagging invalid emails as valid. Instead, we will now use the validates_email_format_of gem to provide more robust email validation. This gem has a superior implementation and is more thoroughly tested.
This PR resolves #1794