Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bogus gateways into payment methods #1977

Closed
wants to merge 1 commit into from

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 29, 2017

In the ongoing effort to remove confusion around payment methods, gateways and providers we rename:

  • Spree::Gateway::Bogus into Spree::PaymentMethod::BogusCreditCard
  • Spree::Gateway::BogusSimple into Spree::PaymentMethod::SimpleBogusCreditCard

In the ongoing effort to remove confusion around payment methods, gateways and providers we rename the Spree::Gateway::Bogus and Spree::Gateway::BogusSimple payment methods into Spree::PaymentMethod::BogusCreditCard and Spree::PaymentMethod::SimpleBogusCreditCard
@tvdeyen
Copy link
Member Author

tvdeyen commented May 29, 2017

Need to rebase #1975 if we decide to make this change

@tvdeyen
Copy link
Member Author

tvdeyen commented Jun 1, 2017

Closing as I plan to move all payment methods into the PaymentMethods module namespace instead, because of constant lookup issues in Rails in combination with STI.

@tvdeyen tvdeyen closed this Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant