Do not show broken links in admin product view when product is deleted #1988
Conversation
andoneve
changed the title
There was a problem hiding this comment.
Thanks for your contribution! I was thinking about wrapping all those elements into a single:
<% if !@product.deleted? %>
but your solution is probably better to keep elements modular.
Another option could be adding a redirect at controller level (that we probably should do anyway) but IMO from a UX point of view is much better to remove/disable those links.
There was a problem hiding this comment.
I think this is a good-enough fix. For sure we would want to add redirects to the controllers, but I'm not sure people would actually try hitting those endpoints (as logged-in admin users...).
Another thought I had is that some of those tabs should actually work with deleted products, as their variants and prices are probably only soft-deleted, too. But that's much more UI work that is probably not worth it.
Thank you for your contribution!
|
Thanks for the comments/feedback. I don't think it's worth adding the redirects in the controller unless you come across the problem (in real life) at some point in the future. This is really a small, dark, unvisited corner of the application. @mamhoff As for looking more into the soft-deleted variants and prices (and why they aren't just there?), I think that's a good idea for the future. |
|
The variant view has been fixed in #1804, so we can actually display that link. Would you mind removing the if condition there, and rebasing? |
Fixes solidusio#1987 - Admin product page for a deleted item shows errors when clicking around. Hides the broken tabs if the product is deleted. Broken: Images, Prices, Product Properties and Product Stock.
Fixes #1987 - Admin product page for a deleted item shows errors when clicking around.
Hides broken tabs (Images, Variants, Prices, Product Stock) in Admin Product View if the product is deleted.