Rename bogus gateways #2000
Rename bogus gateways #2000
Conversation
|
Should we provide something like: Spree::Gateway::Bogus = Spree::PaymentMethod::BogusCreditCard or even class Spree::Gateway::Bogus < Spree::PaymentMethod::BogusCreditCard
def initialize(*args)
#deprecation notice
super
end
enduntil we're ready for a major version release? |
|
@gmacdougall I did this 9443aec ;) |
|
That'll learn me for reading PR's too fast! |
|
No worries, this is a large changeset |
To remove confusion around payment methods, gateways and providers we rename the `Spree::Gateway::Bogus` and `Spree::Gateway::BogusSimple` payment methods into `Spree::PaymentMethod::BogusCreditCard` and `Spree::PaymentMethod::SimpleBogusCreditCard`.
Use `Spree:: PaymentMethod::BogusCreditCard` and `Spree::PaymentMethod::SimpleBogusCreditCard ` instead.
tvdeyen
force-pushed
the
rename-bogus-gateway
branch
2 times, most recently
from
d4862fd to
1e5070c
Compare
|
|
||
| private | ||
|
|
||
| def update(from: , to:) |
|
|
||
| def down | ||
| GATEWAY_MAPPING.inject(0) do |count, mapping| | ||
| count += update(from: mapping[1], to: mapping[0]) |
There was a problem hiding this comment.
Useless assignment to variable - count. Use + instead of +=.
| class << self | ||
| def up | ||
| GATEWAY_MAPPING.inject(0) do |count, mapping| | ||
| count += update(from: mapping[0], to: mapping[1]) |
There was a problem hiding this comment.
Useless assignment to variable - count. Use + instead of +=.
tvdeyen
force-pushed
the
rename-bogus-gateway
branch
from
1e5070c to
0aca193
Compare
|
@mamhoff made a great comment IRL about making the migration class available from the outside (eg. |
tvdeyen
force-pushed
the
rename-bogus-gateway
branch
from
0aca193 to
df02fd9
Compare
|
@mamhoff done! |
| module Migrations | ||
| class RenameGateways | ||
| DEFAULT_MAPPING = [ | ||
| ['Spree::Gateway::Bogus', 'Spree::PaymentMethod::BogusCreditCard'], |
There was a problem hiding this comment.
A good catch, as the keys are unique this will work as well. Thanks!
| module Spree | ||
| describe PaymentMethod::BogusCreditCard, type: :model do | ||
| let(:bogus) { create(:credit_card_payment_method) } | ||
| let!(:cc) { create(:credit_card, payment_method: bogus, gateway_customer_profile_id: "BGS-RERTERT") } |
There was a problem hiding this comment.
Ah right! Now the old files just contains deprecation specs.
This file is empty since: 1fbbdcc
and this seems to be the reason this file was added for:
970eeb6#diff-4f10b6436800df7a8b39eff13961d74f
Maybe we don't need it anymore? Or can it be useful to understand if a payment method can be created with BogusCreditCard payment method? My feeling is that this file is missing some specs, like this one, and of course we can add that with another PR, if they are needed. 😄
There was a problem hiding this comment.
I say let's create a separate PR
Running
rake solidus:migrations:rename_gateways:up
helps migrating your data to new bogus payment method class names.
rake solidus:migrations:rename_gateways:down
reverts this.
Also includes a migration that invokes that task, so you don't need to care when deploying this change.
tvdeyen
force-pushed
the
rename-bogus-gateway
branch
from
df02fd9 to
04dffbf
Compare
To remove confusion around payment methods, gateways and providers we rename the
Spree::Gateway::BogusandSpree::Gateway::BogusSimplepayment methods intoSpree::PaymentMethod::BogusCreditCardandSpree::PaymentMethod::SimpleBogusCreditCard.