Emit Spree.url deprecation warning in all envs #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been deprecated forever, but I'm still not confident enough to remove it. It's possible that it hasn't been seen by users because Spree.env has been unset (as it is in our default frontend). This commit changes the warning to be issued always (so long as console and console.warn are defined).
Previously we were sending our data as a query string, instead we should send it as JSON, since this is a PUT request. This also avoids using the deprecated Spree.url
tvdeyen
approved these changes
Jun 14, 2017
gmacdougall
approved these changes
Jun 14, 2017
I don't think |
This suggestion could be confusing because Spree.ajax isn't a direct replacement of Spree.url
tvdeyen
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been deprecated forever, but I'm still not confident enough to remove it. It's possible that it hasn't been seen by users because
Spree.envhas been unset (as it is in our default frontend).This commit changes the warning to be issued always (so long as console and console.warn are defined).
This also removes a call to
Spree.urlfrom solidus_frontend.