Deprecate Shipment#add_shipping_method #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a convenience method which was used in specs to add a shipping rate with a given shipping method. However it isn't suitable for use outside of specs it doesn't handle having an existing selected rate and doesn't calculate the correct cost. In specs it would be better just to create the shipping_rate instead of using this method, as it will be more obvious what is going on.
tvdeyen
approved these changes
Jun 14, 2017
gmacdougall
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a convenience method which was used in specs to add a shipping rate with a given shipping method. However it isn't suitable for use outside of specs. It doesn't handle having an existing selected rate and doesn't calculate the correct cost.
In specs it would be better just to create the shipping_rate instead of using this method, as it will be more obvious what is going on.