Use normal <select> in admin Customer Details step #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the country and state input used select2. In the past, using select2 was the only way to style a select consistently with the rest of our inputs. This replaces the select2 on country and state with a normal select with has bootstrap's custom-select styling applied. This doesn't replace the "Choose a customer" select2 input, which is still needed since it searches and fetches ajax data.
Senjai
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the country and state input used select2. In the past, using select2 was the only way to style a select consistently with the rest of our inputs.
This replaces the select2 on country and state with a normal select with has bootstrap's custom-select styling applied.
This doesn't replace the "Choose a customer" select2 input, which is still needed since it searches and fetches ajax data.