[RFC] Introduce preference fields partials #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
changelog:solidus_backend
tvdeyen
force-pushed
the
preference-fields-partials
branch
from
1c59edf to
0cf4d1d
Compare
tvdeyen
force-pushed
the
preference-fields-partials
branch
from
0cf4d1d to
83640b8
Compare
jhawthorn
reviewed
Jul 18, 2017
| <%= form.check_box attribute, html_options %> | ||
| <%= form.label attribute, label %> | ||
| <% else %> | ||
| <%= hidden_field_tag name, 0 %> |
There was a problem hiding this comment.
I wonder if we can simplify these cases using the new form_with 🤔
There was a problem hiding this comment.
Good question. Would be nice though. Will give it a try
There was a problem hiding this comment.
Turns out this would be tricky, because we would need to rewrite all forms rendering these fields. In terms of the calculator fields this means to rewrite the calculator forms. I think we should tackle this in a separate PR. WDYT?
There was a problem hiding this comment.
Yeah, let's tackle this later.
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| ## Solidus 2.3.0 (master, unreleased) | |||
|
|
|||
| - Deprecates several preference fields helpers in favor of preference field partials. [\#2040](https://github.com/solidusio/solidus/pull/2040) ([tvdeyen](https://github.com/tvdeyen)) | |||
There was a problem hiding this comment.
Can we bump this forward to 2.4?
tvdeyen
force-pushed
the
preference-fields-partials
branch
from
83640b8 to
3241507
Compare
jhawthorn
approved these changes
Aug 30, 2017
mamhoff
approved these changes
Aug 30, 2017
tvdeyen
force-pushed
the
preference-fields-partials
branch
from
3241507 to
a12383a
Compare
Preference fields are used in several places all over the Solidus admin. Some of them are: - Shipping and tax rate calculator fields - Payment method preferences - Promotion action calculator fields Instead of using a string concatinator helper - that just concatinate the fields and labels with `<br>` - we introduce partials that can easily be overriden by stores and extensions.
Instead of using a custom helper to render input fields for preferences of calculators we render the newly introduced preference fields partials.
This deprecates the follwoing preference fields helpers: - `preference_field_tag` - `preference_field_for` - `preference_field_options` - `preference_fields` Please render the fields for calculators and preferences directly.
Due to the newly introduced preference fields partials all preference fields are now wrapped inside its own field wrapper. Therefore we need to adjust the padding of the calculator preferences of promotion actions.
tvdeyen
force-pushed
the
preference-fields-partials
branch
from
a12383a to
8f690bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preference fields are used in several places all over the Solidus admin. Some of them are:
Instead of using a string concatinator helper - that just concatinate the fields and labels with
<br>This deprecates the follwoing preference fields helpers:
preference_field_tagpreference_field_forpreference_field_optionspreference_fieldsBefore
After