Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Spree::OrderCapturing class #2076

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 11, 2017

This task was added to automate capturing pending payments on a regular basis via a rake task. This kind of custom business logic should not be maintained by us. Half of the class features is not even used by the provided rake task and it makes further improvements around payments harder to test.

@tvdeyen
Copy link
Member Author

tvdeyen commented Jul 11, 2017

Prerequisite for #2075

@tvdeyen tvdeyen requested a review from jordan-brough July 11, 2017 13:37
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 removing this code from Solidus.

Copy link
Contributor

@jordan-brough jordan-brough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvdeyen in what way does this block #2075?

@tvdeyen
Copy link
Member Author

tvdeyen commented Jul 12, 2017

@jordan-brough the tests in #2075 fail because the specs for Spree::OrderCapturing fail.

Verified

This commit was signed with the committer’s verified signature.
kennyadsl Alberto Vena
This task was added to automate capturing pending payments on a regular basis via a rake task. This kind of custom business logic should not be maintained by us. Half of the class features is not even used by the provided rake task and it makes further improvements around payments harder to test.
@tvdeyen tvdeyen force-pushed the remove-order-capturing branch from b1840fe to 0cd9684 Compare July 19, 2017 10:28
@tvdeyen tvdeyen merged commit 4a483ea into solidusio:master Jul 27, 2017
@tvdeyen tvdeyen deleted the remove-order-capturing branch July 27, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants