Add Api::CreditCardsController#update endpoint #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nest #index tests in their own 'describe' block. Prep for adding an #update action.
To allow updating a user's credit cards. E.g. updating the name or address on a credit card from the 'my account' page.
|
👍 |
| @@ -10,6 +10,10 @@ def permitted_attributes | |||
| to: :permitted_attributes, | |||
| prefix: :permitted | |||
|
|
|||
| def permitted_credit_card_attributes | |||
| permitted_source_attributes | |||
There was a problem hiding this comment.
I don't think we use this for user facing authorization.
The user can change the following:
[:number,
:month,
:year,
:expiry,
:verification_value,
:first_name,
:last_name,
:cc_type,
:gateway_customer_profile_id,
:gateway_payment_profile_id,
:last_digits,
:name,
:encrypted_data]
There was a problem hiding this comment.
@Senjai if that's an issue then I don't think it's specific to this PR is it? Those attributes are already exposed via payments_attributes -> source_attributes on the order (when creating a payment). Perhaps we need a separate PR for that if it's an issue?
|
👍 |
|
👍 . |
More accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow updating a user's credit cards. E.g. updating the name or
address on a credit card from the 'my account' page.