Deprecate tasks in core/lib/tasks #2080

cbrunsdon · 2017-07-12T01:06:54Z

None of these tasks should be used by people.

This deprecates those tasks, and removes a dependency that exists just to support these tasks (highline).

houndci-bot · 2017-07-12T01:07:06Z

core/lib/tasks/core.rake

@@ -1,10 +1,16 @@
 require 'active_record'

+def prompt_for_agree prompt
+  print prompt
+  return  ["y", "yes"].include? STDIN.gets.strip.downcase


Redundant return detected.
Unnecessary spacing detected.

houndci-bot · 2017-07-12T01:07:06Z

core/lib/tasks/core.rake

@@ -1,10 +1,16 @@
 require 'active_record'

+def prompt_for_agree prompt


Use def with parentheses when there are parameters.

kennyadsl

I never used these tasks. Just left a small comment, it works for me!

kennyadsl · 2017-07-12T07:52:02Z

core/db/seeds.rb

-Rake::Task['db:load_dir'].reenable
-Rake::Task['db:load_dir'].invoke(default_path)
+['stores', 'store_credit', 'countries', 'return_reasons', 'states',
+ 'stock_locations', 'zones', 'refund_reasons', 'roles', 'shipping_categories'].each do |seed|


I like formatting this kind of array with each element in a separate line, mainly to keep git commits history clean if we change something, but it's just my personal preference, I'm ok with this as well.

Yes. I also would like to have this separated by line 👍

And maybe use %w() syntax, but I don't care about this very much.

tvdeyen

Great improvement.

tvdeyen · 2017-07-12T09:06:41Z

core/db/seeds.rb

-Rake::Task['db:load_dir'].reenable
-Rake::Task['db:load_dir'].invoke(default_path)
+['stores', 'store_credit', 'countries', 'return_reasons', 'states',
+ 'stock_locations', 'zones', 'refund_reasons', 'roles', 'shipping_categories'].each do |seed|


Yes. I also would like to have this separated by line 👍

And maybe use %w() syntax, but I don't care about this very much.

tvdeyen · 2017-07-12T09:07:44Z

core/lib/tasks/core.rake

 namespace :db do
  desc 'Loads a specified fixture file:
 use rake db:load_file[/absolute/path/to/sample/filename.rb]'

  task :load_file, [:file, :dir] => :environment do |_t, args|
+    ActiveSupport::Deprecation.warn("load_file has been deprecated. Please load your own file.")


Spree::Deprecation.warn

I think we can be a little more verbose/descriptive on this deprecation notice

rake spree:load_dir has been deprecated and will be removed with Solidus 3.0. Please load your seed files directly from your app's db/seeds.rb file.

tvdeyen · 2017-07-12T09:08:11Z

core/lib/tasks/core.rake

@@ -13,6 +19,7 @@ use rake db:load_file[/absolute/path/to/sample/filename.rb]'

  desc "Loads fixtures from the the dir you specify using rake db:load_dir[loadfrom]"
  task :load_dir, [:dir] => :environment do |_t, args|
+    ActiveSupport::Deprecation.warn("load_dir has been deprecated. Please load your own files.")


Spree::Deprecation.warn

tvdeyen · 2017-07-12T09:12:29Z

core/lib/tasks/core.rake

@@ -32,9 +39,9 @@ use rake db:load_file[/absolute/path/to/sample/filename.rb]'

  desc "Migrate schema to version 0 and back up again. WARNING: Destroys all data in tables!!"
  task remigrate: :environment do
-    require 'highline/import'
+    ActiveSupport::Deprecation.warn("remigrate has been deprecated. Please demigrate and then migrate again, I guess?")


I think rake db:reset is what we want to recommend, no?

Also Spree::Deprecation.warn

Nothing in this file uses highline, say_status comes from thor

Using load_dir doesn't provide us much benefit over calling all of them ourselves here.

We're only using highline for a few, should-probably-not-be-used methods rake tasks.

cbrunsdon · 2017-07-17T17:13:28Z

Cleaned up the list of seeds and removed any trace of humour from the deprecations

tvdeyen

Nice

mamhoff

There's a word too much still in a deprecation notice, otherwise great!

mamhoff · 2017-07-17T20:30:31Z

core/lib/tasks/core.rake

@@ -13,6 +19,7 @@ use rake db:load_file[/absolute/path/to/sample/filename.rb]'

  desc "Loads fixtures from the the dir you specify using rake db:load_dir[loadfrom]"
  task :load_dir, [:dir] => :environment do |_t, args|
+    Spree::Deprecation.warn("rake spree:load_dir has been deprecated and will be removed with Solidus 3.0. Please load your files directly file.")


Please load your files directly file. I think there's a file too much.

Nothing here should be used by people.

All the tasks in this file are deprecated ref solidusio#2080

houndci-bot reviewed Jul 12, 2017

View reviewed changes

cbrunsdon force-pushed the remove_highline branch 4 times, most recently from 9866727 to 605d576 Compare July 12, 2017 01:10

kennyadsl approved these changes Jul 12, 2017

View reviewed changes

tvdeyen reviewed Jul 12, 2017

View reviewed changes

cbrunsdon added 3 commits July 17, 2017 09:47

Remove unused highline import

564d7c2

Nothing in this file uses highline, say_status comes from thor

Explicitly require seed files

1b22c7d

Using load_dir doesn't provide us much benefit over calling all of them ourselves here.

Remove highline dependency

3dcbda0

We're only using highline for a few, should-probably-not-be-used methods rake tasks.

cbrunsdon force-pushed the remove_highline branch from 605d576 to 06a2d76 Compare July 17, 2017 17:12

tvdeyen approved these changes Jul 17, 2017

View reviewed changes

mamhoff approved these changes Jul 17, 2017

View reviewed changes

Deprecate tasks in lib/tasks/core

cc19db9

Nothing here should be used by people.

cbrunsdon force-pushed the remove_highline branch from 06a2d76 to cc19db9 Compare July 17, 2017 20:41

tvdeyen merged commit 4bd670a into solidusio:master Jul 21, 2017

DanielePalombo added a commit to nebulab/solidus that referenced this pull request Nov 27, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

38d0ad4

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Dec 9, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

5d27c28

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Dec 10, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

bd262fc

All the tasks in this file are deprecated ref solidusio#2080

DanielePalombo added a commit to nebulab/solidus that referenced this pull request Dec 11, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

009f5c8

All the tasks in this file are deprecated ref solidusio#2080

DanielePalombo added a commit to nebulab/solidus that referenced this pull request Dec 11, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

3c8524d

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Dec 15, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

96a5bb9

All the tasks in this file are deprecated ref solidusio#2080

DanielePalombo added a commit to nebulab/solidus that referenced this pull request Dec 18, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

0a682a2

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Dec 21, 2020

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

7be5592

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Jan 19, 2021

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

e580c3f

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Jan 28, 2021

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

fd217aa

All the tasks in this file are deprecated ref solidusio#2080

kennyadsl pushed a commit to nebulab/solidus that referenced this pull request Jan 28, 2021

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

ec2e69d

All the tasks in this file are deprecated ref solidusio#2080

rmparr pushed a commit to rmparr/solidus that referenced this pull request Jun 1, 2022

Remove Deprecated db tasks load_file, load_dir, remigrate, bootstrap

f839aaa

All the tasks in this file are deprecated ref solidusio#2080

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate tasks in core/lib/tasks #2080

Deprecate tasks in core/lib/tasks #2080

cbrunsdon commented Jul 12, 2017 •

edited

Loading

houndci-bot Jul 12, 2017

houndci-bot Jul 12, 2017

kennyadsl left a comment

kennyadsl Jul 12, 2017

tvdeyen Jul 12, 2017

tvdeyen left a comment

tvdeyen Jul 12, 2017

tvdeyen Jul 12, 2017

tvdeyen Jul 12, 2017

tvdeyen Jul 12, 2017

tvdeyen Jul 12, 2017

cbrunsdon commented Jul 17, 2017

tvdeyen left a comment

mamhoff left a comment

mamhoff Jul 17, 2017

		@@ -1,10 +1,16 @@
		require 'active_record'

		def prompt_for_agree prompt

Deprecate tasks in core/lib/tasks #2080

Deprecate tasks in core/lib/tasks #2080

Conversation

cbrunsdon commented Jul 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennyadsl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tvdeyen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbrunsdon commented Jul 17, 2017

tvdeyen left a comment

Choose a reason for hiding this comment

mamhoff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbrunsdon commented Jul 12, 2017 •

edited

Loading