Add missing default_currency field on admin/stores #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Jul 14, 2017
|
|
||
| @store = Spree::Store.last | ||
|
|
||
| expect(@store.default_currency).to eq 'EUR' |
There was a problem hiding this comment.
@oeN maybe we should also test that the currency wasn't EUR before selecting/saving it?
The Spree::Store have a default_currency field that is used in `core/lib/spree/core/controller_helpers/pricing.rb` but never valorized because the field was missing from the store form.
oeN
force-pushed
the
add-store-default-currency
branch
from
54708fd to
e1cb3b3
Compare
kennyadsl
approved these changes
Jul 14, 2017
jhawthorn
approved these changes
Jul 14, 2017
cbrunsdon
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spree::Store have a default_currency field that is used in
core/lib/spree/core/controller_helpers/pricing.rbbut never valorizedbecause the field was missing from the store form.