Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move users search form above table #2094

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Move users search form above table #2094

merged 1 commit into from
Jul 21, 2017

Conversation

graygilmore
Copy link
Contributor

@graygilmore graygilmore commented Jul 17, 2017 •
edited
Loading

Before

screen shot 2017-07-17 at 3 13 32 pm

After

screen shot 2017-07-17 at 3 34 33 pm

@jhawthorn
Copy link
Contributor

jhawthorn commented Jul 17, 2017 •
edited
Loading

Should the search field label be on it's own line above the input? That's the pattern we've used elsewhere

@jhawthorn jhawthorn added changelog:solidus_backend Changes to the solidus_backend gem UI labels Jul 17, 2017
@graygilmore
Move users search form above table
e0ce526 
This allows shops a greater area to add more columns to search by as
well as matches the styling to other searchable index listings.
@graygilmore
Copy link
Contributor Author

Forgot about the form-control class from Bootstrap.

@tvdeyen
Copy link
Member

tvdeyen commented Jul 18, 2017

Reminds me to continue working on #1842 ☺️

jhawthorn
jhawthorn approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tvdeyen tvdeyen merged commit 6536efd into solidusio:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhawthorn jhawthorn jhawthorn approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graygilmore @jhawthorn @tvdeyen