Add YARD documentation to Product and Variant models #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| # variant. | ||
| # | ||
| # @!attribute [rw] prototype_id | ||
| # @return [Fixnum] |
There was a problem hiding this comment.
Document attributes right above their attr_*, not in the class docstring. I'd expect that to be a class attribute.
There was a problem hiding this comment.
Also @seantaylor, you're busted. This attribute is doc'ed as being [rw] but it's actually only a reader!
There was a problem hiding this comment.
Sorry Sean, it is writable but @alexblackie moved things around so the writer was way down the file. 👎
|
nice! I'm not a yard expert but this looks great to me. 👍 |
gmacdougall
added a commit
that referenced
this pull request
May 7, 2015
Add YARD documentation to Product and Variant models
jordan-brough
added a commit
to jordan-brough/solidus
that referenced
this pull request
Sep 5, 2017
…evel-adjustments [Solidus 2.4? PR 2188] Update Solidus to work correctly with non-promotion line-level adjustments
Deploying with
|
| Latest commit: |
8e5adb4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18c6e40c.solidus-guides.pages.dev |
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
Make lanes configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jarednorman