Override model_name.human for PaymentMethod #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 21, 2017
| # subclasses as just "PaymentMethod" | ||
| class ModelName < ActiveModel::Name | ||
| # Similar to ActiveModel::Name#human, but skips lookup_ancestors | ||
| def human(options={}) |
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
tvdeyen
approved these changes
Jul 22, 2017
|
Ah, you already added the milestone. Thanks |
Recently we started using model_name.human instead of the raw class name when displaying the names of payment methods. Unfortunately, if there isn't an i18n key for that specific payment method, model_name.human will fall back to "Payment Method", which is not at all helpful in distinguishing it. This commit changes PaymentMethod.model_name to return a custom ActiveModel::Name subclass, which will use exact matches for translations but doesn't fall back to "Payment Method", and instead will use the "humanized" class name if there is no key.
jhawthorn
force-pushed
the
payment_method_translation
branch
from
18a1f80 to
ef2c1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we started using
model_name.humaninstead of the raw class name when displaying the names of payment methods.Unfortunately, if there isn't an i18n key for that specific payment method, model_name.human will fall back to "Payment Method", which is not at all helpful in distinguishing it.
This commit changes
PaymentMethod.model_nameto return a customActiveModel::Namesubclass, which will use exact matches for translations but doesn't fall back to "Payment Method", and instead willuse the "humanized" class name if there is no key.
Fixes #2106