Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout email input field should use email_field #2120

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Checkout email input field should use email_field #2120

merged 1 commit into from
Aug 18, 2017

Conversation

notapatch
Copy link
Contributor

  • on frontend checkout/edit
  • mobile users will have a virtual keyboard that now includes
    an @ symbol.
  • fallback for none HTML 5 browsers is to text type

@graygilmore
Copy link
Contributor

Makes sense to me! 👍

jhawthorn
jhawthorn approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jhawthorn
Copy link
Contributor

I'm not sure why CircleCI refuses to build this, I have sent them a support request.

@swcraig swcraig mentioned this pull request Aug 17, 2017
Closed
@swcraig
Copy link
Contributor

swcraig commented Aug 17, 2017

I rebased this and opened a new PR in which CircleCI passed.

@cbrunsdon
Copy link
Contributor

I think we can write this up to a circleci blip, I don't care if we merge this one or #2166

@notapatch
Checkout email input field should use email_field
e005428 
 - on frontend checkout/edit
 - mobile users will have a virtual keyboard that now includes
   an @ symbol
 - fallback for non-HTML 5 browsers is to text type
@notapatch notapatch force-pushed the checkout_email_entry branch from 6efceb5 to e005428 Compare August 18, 2017 09:10
@notapatch
Copy link
Contributor Author

Rebased and updated the commit message improvements from @swcraig, thanks.

I am hoping this will be my first Solidus contribution. I won't lie anything else will result in disappointed cockatoo reaction and you don't want to go into a weekend with that on your conscious.

@mamhoff mamhoff merged commit ff423c0 into solidusio:master Aug 18, 2017
@notapatch notapatch deleted the checkout_email_entry branch August 18, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@notapatch @graygilmore @jhawthorn @swcraig @cbrunsdon @kennyadsl @mamhoff