Allow dev mode code reloading of configured classes #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
class_name_attribute
branch
from
2a9d7c0 to
23de93c
Compare
|
I don't know this topic very well but I'm curious why we didn't used the Rails |
The purpose of this is to call |
kennyadsl
reviewed
Aug 2, 2017
mamhoff
approved these changes
Aug 16, 2017
mamhoff
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a change was made to one of the classes configured in
Spree::Config, the changes wouldn't apply until the development server was restarted. This is because we stored a reference to the exact class, and it would not use the new version of the class loaded by code reloading.This PR changes the attributes to store the class
name, and to#constantizeit when accessed. This is similar to the change made in #1203 to the arrays of classes for calculators, payment methods, etc.