Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Sass Organization #2133

Merged
merged 12 commits into from
Aug 15, 2017
Merged

Conversation

graygilmore
Copy link
Contributor

This is just some basic cleanup of the admin Sass. There is more that can be done but that will come as we slowly move over to using Bootstrap's components (e.g., replacing our flashes with Bootstrap's alerts).

The biggest part of this is deprecating the .state component. Fortunately we can just use @extend to have it hook directly into our new .pill component. This will allow any extensions that are currently using .state classes to still function properly and get the new styling.

Blocked

We don't need to have these variables defined twice in two separate
locations. This file is specifically for values that differ from
Bootstrap defaults.
These are Bootstrap variables so they should reside in our
`bootstrap_custom` override file.
These color values can be applied directly to our Boostrap override.
These are no longer necessary and can be set directly in our Bootstrap
override.
These should be set directly in our Bootstrap override. This will also
allow us to more easily change this in the near future.
Bootstrap already provides a variable for us to override so we should
use that instead.
Now that we have the Pill component there should be no area in the
system that uses the old state component. As a fallback we can `@extend`
the new Pill component in an effort to help out some stores that may
have some customizations.
These aren't being used anywhere in the admin so we should remove them.
Instead of referring to generic `$color-1` variables we should be using
explicitly named Sass variables.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes make sense.

@jhawthorn jhawthorn merged commit b518ca4 into solidusio:master Aug 15, 2017
@jhawthorn jhawthorn mentioned this pull request Aug 15, 2017
1 task
@graygilmore graygilmore deleted the sass-organization branch August 16, 2017 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants