Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fixes for taxons tree #2148

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 11, 2017

Since we removed skeleton.css from them admin we need to fix the taxons tree action buttons
position. We need to use Bootstraps float-right instead of Skeletons right.

Also fixes the visual appearance of the root taxon so it does not look like it were sortable.

Former the root taxon in the sortable taxons tree was displayed as a sortable
handle, but it is actually not sortable.
Since we removed skeleton.css and use bootstrap only we need to
use the float-right class to pull the action icons in the taxons
tree to the right.
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhawthorn jhawthorn merged commit 58d73d3 into solidusio:master Aug 14, 2017
@tvdeyen tvdeyen deleted the taxons-tree-fixes branch August 14, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants