New Admin table styles #2159
Merged
New Admin table styles #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstap handles the bulk of the styling and we no longer need these extra styles.
This increases data scanability.
Now that we have new table styles where table headings are aligned to the left by default we want our table cells to follow suit.
These no longer apply any styles. If striping is desired this can be much more easily accomplish by using nth-child in your CSS.
Now that we are using Bootstrap table styles we no longer need to push around pixels like this.
This was necessary before switching to Bootstrap table styles but this class now has no effect.
This will make sure that the table headers properly line up with their content below.
Now that the majority of text is left aligned this will make multi-line table cells easier to read.
The table cell for the sortable handle of the options types form was not present for newly builded records. The cell should always be present only the handle should be hidden.
The stock management table still had a lot of redundant styles.
Bootstrap already declares taht all table cells are vertically top aligned
The handle of sortable tables did not correctly align to the text content of the other table cells. Because of the new vertical alignment of our new table style we need to adjust this. Also removes a duplicate `table td .handle` declaration.
Our new table style vertically top aligns all table cells. Sortable tables are one liners and often have input fields in them. In conjuntion with the sortable handle this leads to erroneous looking UI.
jhawthorn
force-pushed
the
admin-new-table-styles
branch
from
eced77d to
f772767
Compare
cbrunsdon
approved these changes
Aug 17, 2017
|
🎉 🎊 💪 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #2092 (with @tvdeyen's changes included)