Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak font styles on admin shipments page #2164

Merged
merged 3 commits into from
Aug 18, 2017

Conversation

jhawthorn
Copy link
Contributor

This PR:

  • Removes bold from shipping method name (this is a value, not a heading)
  • Removes bold from adjustment name values (this is a value, not a heading)
  • Italicizes "No tracking details provided." (to make it clearer this is a placeholder)

Before

After

@jhawthorn jhawthorn added changelog:solidus_backend Changes to the solidus_backend gem UI labels Aug 17, 2017
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that change.

Also I think we should add some kind of label/header to Shipping Method and Tracking number. When editing these values we have labels above the form fields. That leads to jumpy UI. But we can tackle this later.

@Mandily
Copy link
Contributor

Mandily commented Aug 17, 2017

Visually looks good to me 👍

@tvdeyen
Copy link
Member

tvdeyen commented Aug 17, 2017

WIP, but this is what I have right now

shipments - r987654321 - orders 2017-08-18 00-56-08

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a great improvement. I love semantic typography, and I really think it helps people. I also like @tvdeyen's horizontal table headers, but i guess we can do that in a different PR.

@tvdeyen
Copy link
Member

tvdeyen commented Aug 18, 2017

but i guess we can do that in a different PR.

Upcoming

@tvdeyen tvdeyen merged commit e94ac22 into solidusio:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants