Show table borders on action columns #2165
Conversation
Previously, the action icons were shown clearly outside the table row they belonged to. I suspect this is just because it looked bad. With the new table design, I believe it looks better to group the actions under the same row separator as the rest of the row, and it makes it more obvious what it is operating on. This also right-aligns the action cells.
|
Some people may find it weird that the actions are right aligned, especially on tables with unequal actions item counts
I like it 👍 |
|
When thinking about the alignment of the action buttons - the thing that I would most want to align to is the same action above or below the current row. So a particular action could always be found by scanning straight down. It's one more little piece (location) that helps a user identify what the action is. Kind of like how a colour blind person knows that the top light on a traffic light is stop even though they don't see red. For example: all of the X's would line up straight down the side. Thoughts? |
|
Aligning the identical actions looks good (for the cases it makes sense), but I suspect we'd have to do it with some sort of placeholder element. This PR won't help or hurt our ability to do that in the future. |
Previously, the action icons were shown clearly outside the table row they belonged to. I suspect this is just because it looked bad.
With the new table design, I believe it looks better to group the actions under the same row separator as the rest of the row, and it makes it more obvious what it is operating on.
This also right-aligns the action cells.
Before
Note extra whitespace at right
After
