Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes padding of lists in form fields #2170

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 18, 2017

Lists items in form fields are used for inline checkboxes (ie. order payment form or user roles select).

Somehow a left padding sneaked into that some while ago. This removes the padding as well as the top border, so it suites better for our form style.

Before

users roles - before

customer details - r987654321 - orders 2017-08-18 14-01-44

new payment - payments - r987654321 - orders 2017-08-18 14-03-08

After

users roles - after

customer details - r987654321 - orders 2017-08-18 14-02-22

new payment - payments - r987654321 - orders 2017-08-18 14-03-36

Lists items in form fields are used for inline checkboxes (ie. order payment form or user roles select).

Somehow a left padding sneaked into that some while ago. This removes the padding as well as the top border, so it suites better for our form style.
@tvdeyen tvdeyen added changelog:solidus_backend Changes to the solidus_backend gem UI labels Aug 18, 2017
Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't pulled it down and clicked around but looks like a good change from the screens

@jhawthorn jhawthorn merged commit a3836f3 into solidusio:master Aug 22, 2017
@tvdeyen tvdeyen deleted the field-list-fix branch February 14, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants