Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checkout billing address inputs full width #2171

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Make checkout billing address inputs full width #2171

merged 1 commit into from
Aug 21, 2017

Conversation

notapatch
Copy link
Contributor

  • shipping address already has input elements full width
  • billing address dropdown boxes are already full width
  • change makes billing address consistent with shipping address

@notapatch
Make checkout billing address inputs full width
a2a872a 
 - shipping address already has input elements full width
 - billing address dropdown boxes are already full width
 - change makes billing address consistent with shipping address
@notapatch
Copy link
Contributor Author

notapatch commented Aug 18, 2017 •
edited
Loading

Frontend checkout 'address' page

  • you have to uncheck the "Use Billing Address" checkbox to see the difference
  • Without the change what you see is the input boxes taking up part of the width whereas other elements use the full-width.
  • This change brings Shipping address in line with the Billing Address.
  • When grepping id="billing" I can only find billing in checkout/_address so this change should not affect anything else in the application.

cbrunsdon
cbrunsdon approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, also could only find the one use of #billing

Thanks again @notapatch

tvdeyen
tvdeyen approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

jhawthorn
jhawthorn approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jhawthorn jhawthorn merged commit aa0a905 into solidusio:master Aug 21, 2017
@notapatch notapatch deleted the checkout_shipping_address_full_width branch August 21, 2017 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrunsdon cbrunsdon cbrunsdon approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notapatch @tvdeyen @jhawthorn @cbrunsdon